[RESOLVED]FilterName only called some instances(0.2.8sty+ct)

[Obsi]

Noticed authenticated names were occasionally showing up in ladderlog in lowercase. From what I can tell by glancing at the code it's because ePlayerNetID::FilterName is getting called on lines like

Code: Select all

sg_deathDeathZoneWriter << ePlayerNetID::FilterName(target->Player()->GetUserName());

(tron/gWinZone.cpp - line 1581)

but not on lines like

Code: Select all

sg_deathShotFragWriter << prey->GetUserName() << hunter->GetUserName();

(tron/gWinZone.cpp - line 1654)

Not sure if this was intentional or an oversight, but it does result in mismatched capitalization in the ladderlog. A 'gotcha' to watch out for in your parser.

[Z-Man]

The player's user name is already filtered, so those additional calls to FilterName are redundant for players not logged in and just wrong for authenticated players. What source versions did you find them in? I only found them in sty+ct. So, goandfixit

[Obsi]

Code: Select all

--- tron/gWinZone.cpp.orig      2009-09-30 12:07:49.000000000 -0700
+++ tron/gWinZone.cpp   2009-09-30 12:08:50.000000000 -0700
@@ -1578,7 +1578,7 @@
     {
                target->Player()->AddScore(score_deathzone, tOutput(), "$player_lose_deathzone");
     target->Kill();
-               sg_deathDeathZoneWriter << ePlayerNetID::FilterName(target->Player()->GetUserName());
+               sg_deathDeathZoneWriter << target->Player()->GetUserName();
                sg_deathDeathZoneWriter.write();
     }
     else
@@ -2513,7 +2513,7 @@

                        if ( closest )
                        {
-                               sg_deathBasezoneConqueredWriter << ePlayerNetID::FilterName(closest->GetUserName());
+                               sg_deathBasezoneConqueredWriter << closest->GetUserName();
                                if ( enemies_.size() > 0 || sg_defendRate < 0)
                                {
                     tColoredString playerName;

Also noticed team names being filtered by it, did some digging, but wasn't sure if they were previously filtered or not so I left them alone.

[Z-Man]

Yeah, team names should be filtered consistently. Basically to transform whitespace to underscores.

[kyle]

hmmm I must have kept those from previous revisions when I merged with mainline. I'll fix them this week.