camview widget for cockpit

[DDMJ]

r8396:

Code: Select all

*fixed*

[wrtlprnft]

Err, you have to modify the macos project to include cCamview.cpp and cCamview.h.

[DDMJ]

Err, you have to modify the macos project to include cCamview.cpp and cCamview.h.

Haha, yep, I remember nemo had told me about doing that for something else. Anyways, it works now .

[voodoo]

A couple of buxfix + a "main" camview which replace the main rendering when you use it. No other option works on this one.

So I attached the new patch.
Also available as a branch in launchpad. So for those who have pain to apply the patch, just type:
bzr co http://bazaar.launchpad.net/~armagetron ... ad-camview

[Lucifer]

Curious, has this been maintained? I'm wondering how easy it'll be to merge it with the trunk.

[voodoo]

I've tried to keep camview bzr branch (almost) up to date. Last merge of changes from the trunk was done in november without any special issues ... It was still running fine at least on my comp.

There's still 2 minor issues to notice :
- Ed reports me that positioning does not use the same reference as the other widget. Shame on me, I've never looked at this one.
- Also, camviews currently need to be at the end of the cockpit file otherwise next widgets are rendered in the last camview widget. Shame on me (again) for the same reason ...

err, obviously there was a third one that I just read in 0.3.1 release thread: segfault on exit.

[Z-Man]

You may want to merge those commits to the 0.3.1 branch to your branch:

Code: Select all

------------------------------------------------------------
revno: 754
revision-id: z-man@users.sf.net-20090105231059-64ezj2pllnvlf5s6
parent: z-man@users.sf.net-20090105230116-atx8i5qzex0s9rho
committer: Manuel Moos <z-man@users.sf.net>
branch nick: armagetronad
timestamp: Tue 2009-01-06 00:10:59 +0100
message:
  Fixed server compilation.
------------------------------------------------------------
revno: 753
revision-id: z-man@users.sf.net-20090105230116-atx8i5qzex0s9rho
parent: z-man@users.sf.net-20090105225611-m4dvbuxln4jbfd11
committer: Manuel Moos <z-man@users.sf.net>
branch nick: armagetronad
timestamp: Tue 2009-01-06 00:01:16 +0100
message:
  Fixed more warnings.
------------------------------------------------------------
revno: 752
revision-id: z-man@users.sf.net-20090105225611-m4dvbuxln4jbfd11
parent: dave@davefancella.com-20090105192806-vhrs9hj8nr4lrdp0
committer: Manuel Moos <z-man@users.sf.net>
branch nick: armagetronad
timestamp: Mon 2009-01-05 23:56:11 +0100
message:
  Fixed unused variable and variable init order warnings.
------------------------------------------------------------
revno: 751
revision-id: dave@davefancella.com-20090105192806-vhrs9hj8nr4lrdp0
parent: dave@davefancella.com-20090105192648-inoxhljmqqe3dgw7
committer: dave@davefancella.com
branch nick: 0.3.1_test
timestamp: Mon 2009-01-05 13:28:06 -0600
message:
  Credited voodoo for camview

Or you can just wait for them to get merged into trunk and merge them then in a regular update.

[voodoo]

Thx, I'll do the merge.
But I should set the branch as obsolete soon cause if it is merge to the trunk, it will be useless ...

[ed]

Ed reports me that positioning does not use the same reference as the other widget. Shame on me, I've never looked at this one.

After playing with the cockpit further it seems the error is not with the mirror but with the cockpit. Or perhaps I am not understanding it correctly :S
iirc it was something like this...
Some cockpit widgets use the centre of the widget as the reference point. Some use the corner closest to the centre of the screen.
This means that for different widgets you need to use different reference points which makes things confusing when designing cockpits.
Most widgets use the centremost corner, but the cam uses the widget centre. But I later found it was not alone and other widgets also use the centre.

It was a while ago, but I think that's how it was.
Sorry, this is a bad bug report. If you have trouble recreating it I will drag out my old cockpit files and be more specific.

[Lucifer]

There's still 2 minor issues to notice :
- Ed reports me that positioning does not use the same reference as the other widget. Shame on me, I've never looked at this one.

This isn't a release blocker. The map was like that for awhile too.

- Also, camviews currently need to be at the end of the cockpit file otherwise next widgets are rendered in the last camview widget. Shame on me (again) for the same reason ...

err, obviously there was a third one that I just read in 0.3.1 release thread: segfault on exit.

Both of these are fixed in the 0.3.1 branch.