Friends

[Tank Program]

I've got a few more tweaks on this next version, but still include the fatal flaws. Oops. Banzai for languages. I've set it to mates and 'm' as the toggle in the server browser because I was thinking that at some point 'h' could hide servers that are unreachable.

[Z-Man]

I've factored out my pure-bugfix changes, committed them to 0.2.8 and merged them to the trunk.

The rest of the changes, mostly taken as they were by Tank, is distilled in the attached patch. It is against 0.2.8, but should apply fine to the trunk, apart from Makefile.am.

Two more fixes were done to the patch by me:
The vetoing of friends on playback of recordings was removed. Not loading the friends from the recording would break the playback in the server browser.
Leakfix, the config items generated in gFriends.cpp are now stored in an autopointer array.

Oh, z-man's quick and dirty guide to generating and applying patches:

To generate a patch from an SVN checkout, make sure you "svn a"''d all new files you added, then just do from one level above the top source directory:

Code: Select all

svn diff armagetronad | bzip2 > patch.bz2

And to apply a thusly generated pach, just use from the top source directory

Code: Select all

bzcat patch.bz2 | patch -p1

I never found out whether it is possible to generate a patch that does not require the -p1 argument when getting applied; the patch manpage says it will take the bare base filenames if no -p option is supplied.

[Tank Program]

I just applied it to trunk, it applied perfectly except for Makefile.am. Fixed that, compiled, and no more mysterious crashes when going into the server browser with mates filtering enabled.

[Z-Man]

So, what shall we do with it? My impulse would be to just commit it to 0.2.8.

[Tank Program]

Sounds good, but I added one more thing. I was getting a bit fed up with I couldn't tell if the filtering was enabled or not, so I added a little notification after "Server Name" that would show up there if it was enabled. I'm not sure if it's the best place, but it works.

[DDMJ]

We've just got a small interface problem. We need a key to toggle the friends filter in the server browser. "f" would be obvious, but that's already the default key for fullscreen toggle and would not be optimal. "b" like "buddies" is taken by the bookmark function. "p" like "pals" is taken by the ping function. Two possibilities would be "m" for mates or "h" for homies At that point, me and tank ran out of synonyms. Of course, the ingame texts should then be made to match the key.

"d" for dawgs
"e" for ese's

[Lucifer]

a for amigos
l for lunches

[Z-Man]

I like amigos. Everyone knows what that means, which means we do not need to translate it and the keyboard shortcut makes sense everywhere.