SILENCE_ALL on 0.2.8

wrtlprnft · Post by **wrtlprnft** » Sun Mar 08, 2009 11:35 am

About SVN r9136: The functionality dlh built into SILENCE_ALL was already implemented with ENABLE_CHAT.

Actually the old behavior of SILENCE_ALL was quite useful if you joined an organized match and didn't want to see chat from new players: You'd just wait for all players to arrive and then change the value of SILENCE_ALL. That's still possible, you just have to manually unsilence everyone you'd like to hear from now, but it is a little more of a hassle.

Post by **dlh** » Sun Mar 08, 2009 4:10 pm

Oops. I was unaware of ENABLE_CHAT. You can revert my commit—I won't be able to for the next week (vacation with no laptop).

I think SILENCE_ALL is a confusing name, and should be renamed. Perhaps SILENCE_DEFAULT?

Website · Post by **Z-Man** » Sun Mar 08, 2009 4:39 pm

dlh wrote:I think SILENCE_ALL is a confusing name, and should be renamed. Perhaps SILENCE_DEFAULT?

Agreed. And the two functions have little enough overlap to both stay in.