UNSILENCE_ALL_PLAYERS

What do you want to see in Armagetron soon? Any new feature ideas? Let's ponder these ground breaking ideas...
Post Reply
User avatar
smoothice
On Lightcycle Grid
Posts: 45
Joined: Sun Nov 09, 2008 7:54 pm

UNSILENCE_ALL_PLAYERS

Post by smoothice »

I added a new Bazaar branch today (trunk) that has some code in it that enables UNSILENCE_ALL_PLAYERS... and all it does is unsilence everyone. I thought this would be a nice feature for Armagetron. If the console out was put into the language file, it could probably be merged. (If armagetronad-dev feels it would be worthy)
Image
User avatar
-=VcL.Rajinn
Round Winner
Posts: 242
Joined: Fri Aug 29, 2008 9:35 pm

Post by -=VcL.Rajinn »

nice job smoothice =)
Image
User avatar
Tank Program
Forum & Project Admin, PhD
Posts: 6712
Joined: Thu Dec 18, 2003 7:03 pm

Post by Tank Program »

I get the feeling that if this was all you put in your branch, a .patch file would have done just as well.
Image
User avatar
smoothice
On Lightcycle Grid
Posts: 45
Joined: Sun Nov 09, 2008 7:54 pm

Post by smoothice »

Oh, I thought everything was supposed to be put in a branch for merge ease. I can remove it if it's clutter.

Luke-jr also told me a while back to put every new feature in a branch.
Image
epsy
Adjust Outside Corner Grinder
Posts: 2003
Joined: Tue Nov 07, 2006 6:02 pm
Location: paris
Contact:

Re: UNSILENCE_ALL_PLAYERS

Post by epsy »

smoothice wrote:If the console out was put into the language file, it could probably be merged. (If armagetronad-dev feels it would be worthy)
Well, do that.

And a branch is fine.
User avatar
Z-Man
God & Project Admin
Posts: 11710
Joined: Sun Jan 23, 2005 6:01 pm
Location: Cologne
Contact:

Re: UNSILENCE_ALL_PLAYERS

Post by Z-Man »

epsy wrote:And a branch is fine.
Me agrees 100%. The cost of a branch from trunk on LP is minimal; they are all marked as dependant onto trunk, so they only use storage for stuff not on the trunk (and a bit of management). And with a branch, it's easier to add fixes before it gets merged.
Post Reply