0.2.8.3.2: Release process and Bugs: 0.2.8.3.2_rc1

Help test release candidates for the next release
User avatar
Z-Man
God & Project Admin
Posts: 11427
Joined: Sun Jan 23, 2005 6:01 pm
Location: Cologne
Contact:

0.2.8.3.2: Release process and Bugs: 0.2.8.3.2_rc1

Post by Z-Man »

Yep, we're doing another one. We've had some security fixes lately (with corresponding attacks), so better cement them into a release.

First build: 0.2.8-alpha20110722
Changes relative to 0.2.8.3.2: security fixes against Code Hunter's DoS attack, something else we found on the way and the freezer attack. There is also error-free rebranding and compilation fixes for bleeding edge GCC versions.

ChangeLog:

Code: Select all

------------------------------------------------------------------------
r9616 | z-man | 2011-07-22 15:56:06 +0200 (Fri, 22 Jul 2011) | 2 lines

Merging rebranding fixes.

------------------------------------------------------------------------
r9613 | z-man | 2011-07-22 13:51:20 +0200 (Fri, 22 Jul 2011) | 2 lines

Updated NEWS.

------------------------------------------------------------------------
r9612 | z-man | 2011-07-22 13:51:03 +0200 (Fri, 22 Jul 2011) | 2 lines

Whoops, removing function that wasn't supposed to be here again.

------------------------------------------------------------------------
r9611 | z-man | 2011-07-22 13:39:15 +0200 (Fri, 22 Jul 2011) | 2 lines

Merging fixes for errors and warnings with new compilers by dlh.

------------------------------------------------------------------------
r9610 | z-man | 2011-07-22 13:02:15 +0200 (Fri, 22 Jul 2011) | 2 lines

Using our COPYING.

------------------------------------------------------------------------
r9609 | z-man | 2011-07-22 12:50:43 +0200 (Fri, 22 Jul 2011) | 4 lines

Merging security fix:
  Manuel Moos 2011-03-30 Fixing lenleft checks to avoid reading beyond the end of the message.

------------------------------------------------------------------------
r9608 | z-man | 2011-07-22 12:47:05 +0200 (Fri, 22 Jul 2011) | 4 lines

Merging one pure security fix:
  Manuel Moos 2011-03-29 Correctly ignoring fat packets and checking which clients to kick.

------------------------------------------------------------------------
r9607 | z-man | 2011-07-22 12:45:04 +0200 (Fri, 22 Jul 2011) | 5 lines

Merging two pure security fixes from ladle defense branch:
  Manuel Moos 2011-03-27 Don't process server ping responses in server mode. Unless you're the master server, of course.
  Manuel Moos 2011-03-26 Previenting crash when receiving a message with descriptor ID 399 with DEBUG enabled.

------------------------------------------------------------------------
r9606 | z-man | 2011-07-22 12:41:20 +0200 (Fri, 22 Jul 2011) | 2 lines

Merging fix for infinite loops and crashes when clients send very old-style turn commands.
THIS BUILD IS OUTDATED, get the new one instead
Get it from Launchpad here: https://launchpad.net/armagetronad/0.2. ... ha20110722
THIS BUILD IS OUTDATED, get the new one instead

THIS INFORMATION IS OUTDATED, get the new one instead
Or, if you're running Ubuntu, use the PPA: http://wiki.armagetronad.net/index.php? ... stallation , pick the armagetronad-beta brand. (sudo apt-get install armagetronad-beta(-dedicated))
Should work for Debian as well, you just need to pick a suitable version. Hardy should do the trick.
THIS INFORMATION IS OUTDATED, get the new one instead

A word on the rebranding. Apart from the cosmetics, it means that on Windows and Linux, you can install this build and regular stable versions without installer/uninstaller getting confused and without default installation locations overlapping. (Macs don't need this functionality with their self-contained application images). On Linux only currently, configuration files are kept separate for separate brands. Of course, you're free to manually copy configuration over. And for this release, it'll stay limited to Linux. On the trunk, I'll port it over to Windows and the Mac, and I'm thinking about adding menu items to the client that import/export stock configuration from/to the regular releases.
The sources have the rebranding, umm, burned in as well. You can undo that at configure time by configuring via

Code: Select all

progname=armagetronad progtitle="Armagetron Advanced" ./configure <whatever else you'd normally put here>
Your job: test, obviously, and also point out fixes done in 0.2.8 that should go into this. Best via a direct link to the change in bzr/svn. Keep it to the really important stuff. (Yeah, yeah, the rebranding fixes weren't really that important, I admit. But they only affected the build system, just pushing files around, not the code.)

The release code is managed in the 0.2.8.3 branch on svn that has no bzr cousin.

Rejected fix: the fix that made alt-tab in fullscreen mode not destroy windowed mode later. The fix was an upgrade of SDL, and that's too big a change. You can copy in later versions of SDL.dll yourself if you feel like it.

User avatar
Jip
Round Winner
Posts: 397
Joined: Sat Sep 26, 2009 5:32 pm

Re: 0.2.8.3.2: Release process and Bugs

Post by Jip »

Thank you very much for the work. I will report bugs if I find them.

User avatar
dlh
Formerly That OS X Guy
Posts: 2035
Joined: Fri Jan 02, 2004 12:05 am
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by dlh »

Even if the Mac OS X application doesn't require the new rebranding, perhaps the files should be named consistently across all platforms. That is, armagetronad-beta(-dedicated)-[…].dmg instead of the current armagetroand(-dedicated)-[…].dmg format.

User avatar
Z-Man
God & Project Admin
Posts: 11427
Joined: Sun Jan 23, 2005 6:01 pm
Location: Cologne
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by Z-Man »

Right. Done that. I guess I'll just automate the renaming in the upload preparation automation, the Windows builds needed manual renaming, too.

User avatar
DDMJ
Reverse Outside Corner Grinder
Posts: 1882
Joined: Thu Jun 08, 2006 12:15 am
Location: LA, CA, USA, NA
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by DDMJ »

I was running an alpha from June 26th and I noticed there was some transparentish background around the chat and console log which completely got in the way of playing sometimes. Bravo to whoever removed this.

One random bug I guess: I use the ESC button to bring up the ingame menu, but sometimes when I'm chatting and I decide not to send it, I'll hit ESC, but instead of canceling the chat, it will bring up the menu. When I exit the menu, it still thinks I want to say something. Basically, I can only get out of chatting if I just hit enter sending a blank message.

Code: Select all

Player 1: I'm super 1336+1!
.x] Durka:
Lackadaisical: Thanks for telling us that durks
Sorry if this has already been reported before.

User avatar
Z-Man
God & Project Admin
Posts: 11427
Joined: Sun Jan 23, 2005 6:01 pm
Location: Cologne
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by Z-Man »

DDMJ wrote:I was running an alpha from June 26th and I noticed there was some transparentish background around the chat and console log which completely got in the way of playing sometimes. Bravo to whoever removed this.
That's not removed, it's just not in this one. This is just bugfixes of 0.2.8.3.1.
DDMJ wrote:One random bug I guess: I use the ESC button to bring up the ingame menu, but sometimes when I'm chatting and I decide not to send it, I'll hit ESC, but instead of canceling the chat, it will bring up the menu. When I exit the menu, it still thinks I want to say something. Basically, I can only get out of chatting if I just hit enter sending a blank message.

Code: Select all

Player 1: I'm super 1336+1!
.x] Durka:
Lackadaisical: Thanks for telling us that durks
Sorry if this has already been reported before.
That's very odd, the build posted here is, as far as I can tell, not affected by this bug. It has been a bug on the 0.2.8 branch for a bit and is fixed there by now. So have you observed it here?

User avatar
DDMJ
Reverse Outside Corner Grinder
Posts: 1882
Joined: Thu Jun 08, 2006 12:15 am
Location: LA, CA, USA, NA
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by DDMJ »

Yes I have :\/

User avatar
Phytotron
Formerly Oscilloscope
Posts: 5041
Joined: Thu Jun 09, 2005 10:06 pm
Location: A site or situation, especially considered in regard to its surroundings.
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by Phytotron »

Just to be clear: From the first post (and my very lay understanding) it seems most, if not all, of this is related to the server side. Is that right, or are there reasons for the client to be tested as well?

User avatar
Z-Man
God & Project Admin
Posts: 11427
Joined: Sun Jan 23, 2005 6:01 pm
Location: Cologne
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by Z-Man »

DDMJ wrote:Yes I have :\/
Either I screwed up the build, then, or it may be configuration dependent. Can you post a debug recording?

Phytotron: The security fixes are intended to help the server, but all changes can affect the client, too. So both should be tested.

User avatar
dlh
Formerly That OS X Guy
Posts: 2035
Joined: Fri Jan 02, 2004 12:05 am
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by dlh »

I installed armagetronad-beta-dedicated from the PPA. One small issue:

The directory structure was a little odd. My userdatadir was /var/games/armagetronad-beta-dedicated/.armagetronad-beta-dedicated. The var directory with stats could be found at /var/games/armagetronad-beta-dedicated/.armagetronad-beta-dedicated/var, etc…

User avatar
Z-Man
God & Project Admin
Posts: 11427
Joined: Sun Jan 23, 2005 6:01 pm
Location: Cologne
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by Z-Man »

Yep, that's weird. It's what the official Ubuntu package is doing too, though (I checked), so fixing it now would break upgrades from 0.2.8.3.1 to the finished 0.2.8.3.2. I'll see if I can make a patch and submit it for later inclusion.

User avatar
Z-Man
God & Project Admin
Posts: 11427
Joined: Sun Jan 23, 2005 6:01 pm
Location: Cologne
Contact:

Re: 0.2.8.3.2: Release process and Bugs

Post by Z-Man »

THIS BUILD IS OUTDATED, get the new one instead
New build is up: 0.2.8.3-beta20110815. PPA users should be updated automatically in a few hours.
THIS BUILD IS OUTDATED, get the new one instead
Full changes since last build:

Code: Select all

------------------------------------------------------------------------
r9695 | z-man | 2011-08-09 15:59:24 +0200 (Tue, 09 Aug 2011) | 2 lines

Updating NEWS.

------------------------------------------------------------------------
r9694 | z-man | 2011-08-09 15:57:20 +0200 (Tue, 09 Aug 2011) | 2 lines

Adding checks to make sure that no illegal (infinite/NaN) values are passed to OpenGL during cycle trail rendering.

------------------------------------------------------------------------
r9676 | z-man | 2011-08-05 15:55:48 +0200 (Fri, 05 Aug 2011) | 2 lines

Making sysinstall silent again.

------------------------------------------------------------------------
r9675 | z-man | 2011-08-05 15:33:30 +0200 (Fri, 05 Aug 2011) | 2 lines

Spelling fix rampage. Not caring about A/B english right now.

------------------------------------------------------------------------
r9674 | z-man | 2011-08-05 13:57:15 +0200 (Fri, 05 Aug 2011) | 2 lines

More spelling.

------------------------------------------------------------------------
r9672 | z-man | 2011-08-04 13:23:56 +0200 (Thu, 04 Aug 2011) | 2 lines

Merging aspect ratio fix.

------------------------------------------------------------------------
r9671 | z-man | 2011-08-04 11:58:56 +0200 (Thu, 04 Aug 2011) | 2 lines

Shortened display list texts so they fit the screen.

------------------------------------------------------------------------
r9619 | z-man | 2011-07-23 00:43:54 +0200 (Sat, 23 Jul 2011) | 2 lines

Merging another rebranding fix.
Please check the client mostly; the two important merges are the aspect ratio fix, making widescreen really widescreen and not shortscreen (if you don't have a widescreen monitor, use horizontal splitscreen) and the added tests to cycle trail rendering; for those, just play a bit and watch for anything funky right behind your cycle. The spelling fixes are smaller stuff, don't test them because you didn't spot any of them before, so you wouldn't notice that they're fixed now :) (Apart from the overly long display list tooltip)

Relabeled this _beta because... it's a beta, and to maximally avoid confusion with the 0.2.8_alpha20110815 build that also went up.

Plan: This should be the last untagged build for this release. Then we go straight for 0.2.8.3.2_rc1.

User avatar
Phytotron
Formerly Oscilloscope
Posts: 5041
Joined: Thu Jun 09, 2005 10:06 pm
Location: A site or situation, especially considered in regard to its surroundings.
Contact:

Re: 0.2.8.3.2: Release process and Bugs: 0.2.8.3_beta2011081

Post by Phytotron »

Those display lists tooltips are still cut off, at the same spot.

User avatar
Z-Man
God & Project Admin
Posts: 11427
Joined: Sun Jan 23, 2005 6:01 pm
Location: Cologne
Contact:

Re: 0.2.8.3.2: Release process and Bugs: 0.2.8.3_beta2011081

Post by Z-Man »

Odd, it's only for me in resolutions of 320x240 and lower, and lots of things are then. I specifically checked the downloaded Mac version. Are you absolutely sure you're running the correct version? Does the title screen say beta20110815?

User avatar
Phytotron
Formerly Oscilloscope
Posts: 5041
Joined: Thu Jun 09, 2005 10:06 pm
Location: A site or situation, especially considered in regard to its surroundings.
Contact:

Re: 0.2.8.3.2: Release process and Bugs: 0.2.8.3_beta2011081

Post by Phytotron »

Absolutely sure, and yes it does. I trashed the previous alpha before downloading that one. My resolution is 1280x960 (desktop and game).

Post Reply